Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tune matching from best knowledge model #241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

awegsche
Copy link
Contributor

there were two issues:

  • if we match the tunes, MQT settings will be overwritten and it's not our 'best knowledge' anymore
  • the tune matching calls USE internally, which deletes the b2 errors

there were two issues:

- if we match the tunes, MQT settings will be overwritten and it's not
our 'best knowledge' anymore
- the tune matching calls `USE` internally, which deletes the b2 errors
@JoschD
Copy link
Member

JoschD commented Mar 30, 2023

Will there be any problem if we only use the b2 but don't extract the MQTs? We will not have a matched tune then?
In omc3 we now say we always have to extract MQTs, right?
Maybe for python3: Wouldn't it make sense to make an if with a USE_EXTRACTED_MQTS parameter and extract the MQTs via the model creator instead of the GUI when needed?

@awegsche
Copy link
Contributor Author

After discussion, I will add an ESAVE for debugging purposes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants