Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to set a destination directory for the simulation output (local) #34

Merged
merged 31 commits into from
Nov 13, 2023
Merged

Add an option to set a destination directory for the simulation output (local) #34

merged 31 commits into from
Nov 13, 2023

Conversation

JoschD
Copy link
Member

@JoschD JoschD commented Nov 2, 2023 •
edited
Loading

In this tiny PR:

Could this PR have been 4 smaller PRs? Maybe.
But where is the fun in that?

@JoschD JoschD mentioned this pull request Nov 2, 2023
Closed
@JoschD JoschD marked this pull request as draft November 3, 2023 09:43
@JoschD JoschD self-assigned this Nov 7, 2023
@JoschD JoschD added the Type: Feature A (suggetion for a) new feature or enhancement in functionality. label Nov 7, 2023
@JoschD JoschD marked this pull request as ready for review November 8, 2023 18:59
fsoubelet
fsoubelet reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@fsoubelet fsoubelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments here and there. I like the clearer structure and addition of many docstrings.

I suggest updating the CHANGELOG file too before we merge.

doc/conf.py Outdated Show resolved Hide resolved
pylhc_submitter/job_submitter.py Show resolved Hide resolved
pylhc_submitter/job_submitter.py Show resolved Hide resolved
pylhc_submitter/submitter/htc_utils.py Outdated Show resolved Hide resolved
pylhc_submitter/submitter/htc_utils.py Show resolved Hide resolved
pylhc_submitter/submitter/htc_utils.py Outdated Show resolved Hide resolved
pylhc_submitter/submitter/iotools.py Show resolved Hide resolved
pylhc_submitter/submitter/runners.py Outdated Show resolved Hide resolved
tests/unit/test_job_submitter.py Outdated Show resolved Hide resolved
tests/unit/test_job_submitter.py Outdated Show resolved Hide resolved
fsoubelet
fsoubelet reviewed Nov 10, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 10, 2023

Code Climate has analyzed commit b26a9db and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3

The test coverage on the diff in this pull request is 88.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 68.4% (2.4% change).

View more on Code Climate.

@JoschD
Copy link
Member Author

JoschD commented Nov 10, 2023

@anabramo last chance to give it a look, before it will be merged ;)

@anabramo
Copy link

Look great to me!

@JoschD JoschD merged commit 507905c into master Nov 13, 2023
21 checks passed
@JoschD JoschD deleted the eos-output branch November 13, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsoubelet fsoubelet fsoubelet approved these changes

@mihofer mihofer Awaiting requested review from mihofer

@anabramo anabramo Awaiting requested review from anabramo

Assignees

@JoschD JoschD

Labels
Type: Feature A (suggetion for a) new feature or enhancement in functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoschD @anabramo @fsoubelet