Remove unnecessary function and lots of linting #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsoubelet
added
Type: Feature
|
Getting |
JoschD
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three things in this PR:
Lots of linting throughout the code, with no functionality change.
Removed some
skipifmarks that skipped the relevant tests for Python <3.8 since we require 3.9 minimum now.The removal of the
_autoset_pandas_typesfunction. It was essentially a workaround for the potential raise ofValueErrorindf.convert_dtypes(). That raise was a mistake in pandas which was resolved inpandas 1.3.0. Since we now requirepandas >= 2.1it can be removed.No need for a release after merge.