Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to setup-micromamba action #7213

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Mar 22, 2024

Description

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7213.org.readthedocs.build/en/7213/

@maresb maresb force-pushed the setup-micromamba branch 2 times, most recently from fedefb7 to c490e50 Compare March 22, 2024 14:50
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (c17491d) to head (97dc1ca).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7213   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files         106      106           
  Lines       17685    17685           
=======================================
+ Hits        16419    16420    +1     
+ Misses       1266     1265    -1     

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@maresb maresb marked this pull request as ready for review March 22, 2024 16:03
@maresb
Copy link
Contributor Author

maresb commented Mar 22, 2024

I think the error may be fixed here: pymc-devs/pytensor#678

@maresb
Copy link
Contributor Author

maresb commented Mar 29, 2024

Ah ya, thanks, that's the one! (Wrong PR)

Copy link
Member

@twiecki twiecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much simpler.

@ricardoV94
Copy link
Member

Do we need pymc-devs/pytensor#678 here?

@twiecki
Copy link
Member

twiecki commented Apr 5, 2024

Worth a try.

@maresb
Copy link
Contributor Author

maresb commented Apr 5, 2024

Ok, rebased.

@maresb
Copy link
Contributor Author

maresb commented Apr 5, 2024

That's weird, maybe it needs to be rerun?

image

I still find GH's UI here weird. I can't find a rerun button for that task. Maybe I need to wait until the whole thing finishes?

@ricardoV94
Copy link
Member

Yeah, you can only rerun failed runs once everything is done

@maresb
Copy link
Contributor Author

maresb commented Apr 5, 2024

Just started the rerun. Any idea why I can't view logs (see screenshot)? Is this a GH outage?

@maresb
Copy link
Contributor Author

maresb commented Apr 6, 2024

Viewing the CI logs is still really flaky for me, but somehow I was able to get a glimpse of:

 _________________ ERROR collecting tests/sampling/test_jax.py __________________
tests/sampling/test_jax.py:30: in <module>
    from numpyro.infer import MCMC
../../../micromamba/envs/pymc-test/lib/python3.12/site-packages/numpyro/__init__.py:6: in <module>
    from numpyro import compat, diagnostics, distributions, handlers, infer, ops, optim
../../../micromamba/envs/pymc-test/lib/python3.12/site-packages/numpyro/distributions/__init__.py:4: in <module>
    from numpyro.distributions.conjugate import (
../../../micromamba/envs/pymc-test/lib/python3.12/site-packages/numpyro/distributions/conjugate.py:9: in <module>
    from numpyro.distributions.continuous import Beta, Dirichlet, Gamma
../../../micromamba/envs/pymc-test/lib/python3.12/site-packages/numpyro/distributions/continuous.py:36: in <module>
    from jax.scipy.linalg import cho_solve, solve_triangular
../../../micromamba/envs/pymc-test/lib/python3.12/site-packages/jax/scipy/linalg.py:18: in <module>
    from jax._src.scipy.linalg import (
../../../micromamba/envs/pymc-test/lib/python3.12/site-packages/jax/_src/scipy/linalg.py:403: in <module>
    @_wraps(scipy.linalg.tril)
E   AttributeError: module 'scipy.linalg' has no attribute 'tril'

Then for attempt #2, which I believe was post-rebase, I think I was still seeing the old "filename too long" error. 😢 But I can't access the logs in order to paste them here...

Am I the only one who is having trouble viewing the CI logs?

@maresb
Copy link
Contributor Author

maresb commented Apr 6, 2024

Regarding scipy.linalg.tril, see https://docs.scipy.org/doc/scipy-1.11.4/reference/generated/scipy.linalg.tril.html:

Deprecated since version 1.11.0: tril is deprecated in favour of numpy.tril and will be removed in SciPy 1.13.0.

@maresb
Copy link
Contributor Author

maresb commented Apr 6, 2024

Yeah, you can only rerun failed runs once everything is done

@ricardoV94, here I at least have a "Re-run" link, even though it doesn't appear to have actually triggered a rerun yet.

image

@ricardoV94
Copy link
Member

@maresb wanna try to revive this one?

@maresb
Copy link
Contributor Author

maresb commented Oct 10, 2024

Eventually! Thanks @ricardoV94 for the ping. Currently I'm waiting for all the the major micromamba v2 bugs to get resolved before touching this sort of thing.

@maresb maresb mentioned this pull request Nov 20, 2024
11 tasks
@maresb
Copy link
Contributor Author

maresb commented Nov 20, 2024

@lucianopaz, would you be interested in helping me revive this?

There are still issues with micromamba v2, but I think there's a decent chance that they won't be problematic here.

@maresb maresb force-pushed the setup-micromamba branch 3 times, most recently from 91ec1c8 to 3614609 Compare November 20, 2024 10:33
@maresb
Copy link
Contributor Author

maresb commented Nov 20, 2024

Supersedes #7580

Copy link
Contributor

@lucianopaz lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucianopaz lucianopaz merged commit 0082409 into pymc-devs:main Nov 20, 2024
23 checks passed
@maresb maresb deleted the setup-micromamba branch November 20, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants