Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sparse Vstack Op should not be a subclass of Hstack #1162

Open
ricardoV94 opened this issue Jan 21, 2025 · 0 comments
Open

Sparse Vstack Op should not be a subclass of Hstack #1162

ricardoV94 opened this issue Jan 21, 2025 · 0 comments
Labels
Op implementation sparse variables

Comments

@ricardoV94
Copy link
Member

This is a recipe for bug in rewrites. They should be distinct or inherit from a Stack baseclass that contains the common code

pytensor/pytensor/sparse/basic.py

Line 2902 in d4a2b2b

class VStack(HStack):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Op implementation sparse variables
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricardoV94