Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename _output_type_depends_on_input_value #1188

Open
ricardoV94 opened this issue Feb 4, 2025 · 3 comments · May be fixed by #1209
Open

Rename _output_type_depends_on_input_value #1188

ricardoV94 opened this issue Feb 4, 2025 · 3 comments · May be fixed by #1209

Comments

@ricardoV94
Copy link
Member

Description

The Aarray API standard has a name for this: https://data-apis.org/array-api/draft/design_topics/data_dependent_output_shapes.html

Propose renaming it to data_dependent_output_shapes for discoverability / standardization.

_output_type_depends_on_input_value = False
"""
Whether the static output type depends on the inferred value of one of the inputs.
(e.g, via constant folding or static shape inference).
This information is needed when rebuilding a graph with new inputs,
as nodes with these Ops must be rebuilt even if the input types haven't changed.
"""

We should also document it in the Op docs.

@Aarsh-Wankar
Copy link

@ricardoV94 I would like to work on this issue. I found ten places in the codebase where output_type_depends_on_input_value was mentioned. Should I just replace them all with data_dependent_output_shapes?

@ricardoV94
Copy link
Member Author

yes

@Aarsh-Wankar
Copy link

@ricardoV94 I have made the changes; please check. Also, do I need to make any documentation changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants