Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Elemwise a subclass of Blockwise #1212

Open
ricardoV94 opened this issue Feb 16, 2025 · 0 comments
Open

Make Elemwise a subclass of Blockwise #1212

ricardoV94 opened this issue Feb 16, 2025 · 0 comments
Labels
Op implementation refactor

Comments

@ricardoV94
Copy link
Member

Description

All general Blockwise methods (infer_shape, grad, ...) work for Elemwise which is just a trivial Blockwise function with signature "(),()...()->(),...,()` (that is one entry for each input and output).

We should make Elemwise a subclass of Blockwise and remove any redundant methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Op implementation refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricardoV94