-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cross-platform compilation using distutils._msvccompiler.MSVCCompiler
#298
Conversation
0039a79
to
e9eb697
Compare
@@ -28,6 +30,28 @@ def _find_vcvarsall(plat_spec): | |||
'wont find this version', | |||
) | |||
|
|||
@pytest.mark.skipif( | |||
not sysconfig.get_platform().startswith("win"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively:
not sysconfig.get_platform().startswith("win"), | |
sysconfig.get_platform() not in _msvccompiler._vcvars_names, |
or
not sysconfig.get_platform().startswith("win"), | |
get_platform() not in _msvccompiler._vcvars_names, |
But that's starting to look a lot like tests following the implementation
…piler` Actually use the `plat_name` param in `MSVCCompiler.initialize` Added tests
7d0a6d6
to
a0339c1
Compare
@@ -0,0 +1 @@ | |||
Fix cross-platform compilation using ``distutils._msvccompiler.MSVCCompiler`` -- by :user:`saschanaz` and :user:`Avasam` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, gosh. I'm realizing now that we can't use these news fragments. They refer to issues in this repository, which is merged into Setuptools, so adding them here will cause setuptools to render them as their own issues. I'll just delete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right!
Well you could still have newsfragments without issue # if it starts with +
(for example: +distutils298.bugfix.rst
)
In this case it could refer to the issue I opened on setuptools' repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I'll aim to do things like that in the future.
Actually use the
plat_name
param inMSVCCompiler.initialize
Thanks @saschanaz #285 (comment)
Fixes pypa/setuptools#4648 (comment)