Skip to content

Unnecessary to install kernel-devel-$(uname -r) in manylinux1 builder container ? #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xuyang2 opened this issue Apr 2, 2021 · 2 comments
Closed

Unnecessary to install kernel-devel-$(uname -r) in manylinux1 builder container ? #1056

xuyang2 opened this issue Apr 2, 2021 · 2 comments

Comments

@xuyang2
Copy link

xuyang2 commented Apr 2, 2021 •
edited
Loading

Is seems unnecessary to yum install kernel-devel-$(uname -r) in the centos:5 container.
Anyway, uname -r in the container returns the kernel release of the host.

Code:

manylinux/docker/build_scripts/build.sh

Lines 72 to 78 in dbd36f7

diffutils \
expat-devel \
gettext \
kernel-devel-`uname -r` \
file \
make \
patch \

Build log:
https://github.com/pypa/manylinux/runs/2192738056?check_suite_focus=true#step:3:380

 + yum -y install automake bison bzip2 cmake28 devtoolset-2-binutils devtoolset-2-gcc devtoolset-2-gcc-c++ devtoolset-2-gcc-gfortran diffutils expat-devel gettext kernel-devel-5.4.0-1041-azure file make patch unzip which yasm zlib-devel bzip2-devel ncurses-devel sqlite-devel readline-devel tk-devel gdbm-devel db4-devel libpcap-devel xz-devel gpg libffi-devel
Reducing CentOS-5 - libselinux to included packages only
Finished
Setting up Install Process
Package diffutils-2.8.1-16.el5.x86_64 already installed and latest version
No package kernel-devel-5.4.0-1041-azure available.
@xuyang2 xuyang2 changed the title Unnecessary to install kernel-devel in container? Maybe unnecessary to install kernel-devel in build container ? Apr 2, 2021
@xuyang2 xuyang2 changed the title Maybe unnecessary to install kernel-devel in build container ? Maybe unnecessary to install kernel-devel in builder container ? Apr 2, 2021
@xuyang2 xuyang2 changed the title Maybe unnecessary to install kernel-devel in builder container ? Unnecessary to install kernel-devel in builder container ? Apr 2, 2021
@xuyang2
Copy link
Author

xuyang2 commented Apr 2, 2021 •
edited
Loading

And git grep kernel-devel shows nothing except for the manylinux1 branch.
Seems already updated in main branch.

Relative PRs and commits:

kernel-devel-uname -r -> kernel-devel :
#348
https://github.com/pypa/manylinux/pull/348/files#diff-06397b64e9d4c44493c709ff2d96d126e1ff66b2ee25999c267882770ac7b185R83
03edd41#diff-06397b64e9d4c44493c709ff2d96d126e1ff66b2ee25999c267882770ac7b185R83

kernel-devel -> kernel-headers :
#979
https://github.com/pypa/manylinux/pull/979/files#diff-6356f7ab4b0cce5102991e023f7b3d076661846a9b5d0493d984de2c9fcb4e9cR13
8c24b01#diff-6356f7ab4b0cce5102991e023f7b3d076661846a9b5d0493d984de2c9fcb4e9cR13

@xuyang2 xuyang2 changed the title Unnecessary to install kernel-devel in builder container ? Unnecessary to install kernel-devel-uname -r in builder container ? Apr 2, 2021
@xuyang2 xuyang2 changed the title Unnecessary to install kernel-devel-uname -r in builder container ? Unnecessary to install kernel-devel-${uname -r} in builder container ? Apr 2, 2021
@xuyang2 xuyang2 changed the title Unnecessary to install kernel-devel-${uname -r} in builder container ? Unnecessary to install kernel-devel-$(uname -r) in builder container ? Apr 2, 2021
@xuyang2 xuyang2 changed the title Unnecessary to install kernel-devel-$(uname -r) in builder container ? Unnecessary to install kernel-devel-$(uname -r) in manylinux1 builder container ? Apr 2, 2021
mayeut added a commit to mayeut/manylinux that referenced this issue Apr 4, 2021
@mayeut
[manylinux1] Remove useless kernel-devel-uname -r dependency
620973c 
Remove useless kernel-devel-`uname -r` dependency

The package doesn't exist and thus is not installed.
Fix pypa#1056
@mayeut mayeut mentioned this issue Apr 4, 2021
Merged
mayeut added a commit that referenced this issue Apr 4, 2021
@mayeut
[manylinux1] Remove useless kernel-devel-uname -r dependency (#1059)
b2ee6f6 
Remove useless kernel-devel-`uname -r` dependency

The package doesn't exist and thus is not installed.
Fix #1056
@mayeut
Copy link
Member

mayeut commented Apr 4, 2021

Thanks for the report. This is now fixed.

@mayeut mayeut closed this as completed Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xuyang2 @mayeut