Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing mfile_skip through to format eval #565

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

briochh
Copy link
Collaborator

@briochh briochh commented Dec 16, 2024

PstFrom add_parameters with skip rows and arrays was not getting passed through to format-get methods and was therefore throwing an error.

  • This should fix it
  • Added some testing to catch

Should close #564

@coveralls
Copy link

Coverage Status

coverage: 79.375% (+0.07%) from 79.305%
when pulling 78f562d on briochh:hotfix_skip
into 0d4d87d on pypest:develop.

@briochh briochh merged commit 0f69c6b into pypest:develop Dec 16, 2024
14 checks passed
@briochh briochh deleted the hotfix_skip branch December 16, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mfile_skip getting ignored in pf.add_parameters()
2 participants