Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization of sensors and values #28

Closed
bnordli opened this issue Dec 23, 2023 · 2 comments
Closed

Localization of sensors and values #28

bnordli opened this issue Dec 23, 2023 · 2 comments
Assignees
@leeyuentuen

Comments

@bnordli
Copy link
Contributor

bnordli commented Dec 23, 2023

Sensors and values should be localizable. Currently the English names are hard coded in sensors.py, which makes them impossible to translate.

See https://developers.home-assistant.io/docs/internationalization/core/#entities for more information regarding this.

Excellent work, by the way, I have been waiting for something similar a long time! 🥇
leeyuentuen pushed a commit that referenced this issue Dec 26, 2023
add localization of sensor value fix #28
c4642db
@leeyuentuen
Copy link
Contributor

@bnordli they are now available in the beta version of 1.2.3, can you take a look?

@leeyuentuen leeyuentuen self-assigned this Dec 26, 2023
@bnordli
Copy link
Contributor Author

bnordli commented Dec 31, 2023

Looks great. I reviewed the Norwegian entity names in #54 .

@bnordli bnordli closed this as completed Dec 31, 2023
leeyuentuen pushed a commit that referenced this issue Jan 1, 2024
@leeyuentuen
add localization of sensor value fix #28
d886dde
leeyuentuen pushed a commit that referenced this issue Jan 2, 2024
@leeyuentuen
add localization of sensor value fix #28
6fb8d40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leeyuentuen leeyuentuen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leeyuentuen @bnordli