Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiplication by factor is happening twice for hydro profile #1331

Open
2 tasks done
yerbol-akhmetov opened this issue Feb 3, 2025 · 1 comment · May be fixed by #1346
Open
2 tasks done

Multiplication by factor is happening twice for hydro profile #1331

yerbol-akhmetov opened this issue Feb 3, 2025 · 1 comment · May be fixed by #1346
Labels
bug Something isn't working

Comments

@yerbol-akhmetov
Copy link
Collaborator

Checklist

  • I am using the current main branch or the latest release. Please indicate.
  • I am running on an up-to-date pypsa-earth environment. Update via conda env update -f envs/environment.yaml.

Describe the Bug

Good day, @davide-f, @ekatef. I have noticed that the multiplication by a factor for hydro is performed twice. First, while getting yearly normalized values from EIA, the second time for inflow:

pypsa-earth/scripts/build_renewable_profiles.py

Lines 644 to 657 in 1e6d39a

if method == "hydro_capacities":
path_hydro_capacities = snakemake.input.hydro_capacities
normalize_using_yearly = (
get_hydro_capacities_annual_hydro_generation(
path_hydro_capacities, countries, norm_year
)
* config.get("multiplier", 1.0)
)
elif method == "eia":
path_eia_stats = snakemake.input.eia_hydro_generation
normalize_using_yearly = get_eia_annual_hydro_generation(
path_eia_stats, countries
) * config.get("multiplier", 1.0)

and

pypsa-earth/scripts/build_renewable_profiles.py

Line 668 in 1e6d39a

inflow *= config.get("multiplier", 1.0)

@yerbol-akhmetov yerbol-akhmetov added the bug Something isn't working label Feb 3, 2025
@davide-f
Copy link
Member

davide-f commented Feb 3, 2025

nice catch! one needs to be dropped

@davide-f davide-f linked a pull request Feb 8, 2025 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Index hydro units by their location davide-f/pypsa-earth
2 participants
@davide-f @yerbol-akhmetov