Improve rng default in the contrib/model.py module
#1992
+45
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it is the issue of contrib.module. We can use to optionally create dummy rng_key. I think it does not affect the functionality of the module. |
Do you mean like 5e40979 ? or something has to be changed in |
|
I think changing in contrib is better because we know that key(0) does not change the logic there. If we change it here, users might forget to provide some posterior samples. |
juanitorduz
commented
Mar 1, 2025
Comment on lines
+88
to
+89
| if rng_key is None: | ||
| rng_key = random.key(0) |
There was a problem hiding this comment.
I had to do it this way since rng_key = numpyro.prng_key() or random.key(0) we giving an error
E ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
juanitorduz
changed the title
contrib/model.py module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1991