feat(hermes): add datadog profiling #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Reisen
force-pushed
the
push-uuvuqrytuuop
branch
from
84d9612 to
d492a38
Compare
ali-bahjati
reviewed
Aug 30, 2023
hermes/src/network/p2p.go
Outdated
| ctx := context.Background() | ||
| // Start the datadog profiler. Only starts if an environment is | ||
| // specified and a datadog API key is provided. | ||
| if os.Getenv("DD_PROFILING_ENV") != "" && os.Getenv("DD_API_KEY") != "" { |
There was a problem hiding this comment.
wouldn't it be better if we pass them by cli arguments (which supports env variable as well)?
There was a problem hiding this comment.
Yes I'll change it, I added them with changes to the GO_LOG which I intended to behave similar to RUST_LOG (no arg), this would be better.
ali-bahjati
force-pushed
the
push-uuvuqrytuuop
branch
from
d492a38 to
8454338
Compare
ali-bahjati
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds DataDog profiling to the Go portion of Hermes. Datadog provides two API's, APM tracing and full profiling. APM tracing allows defining meaningful spans over the code to measure, wheras profiling exposes all runtime metrics for the profiling mode specified.
We only have one small hot path in the message handling so the application is relatively simple, initially I opted for APM but tracing seems better.
There is a second option, which is to add
ddprofto the Rust portion but I'm opting against this for now because while it will provide tracing for both the Rust and Go portion, the tracing will not be Go aware and be much more brittle. Ideally it would be nice to enable both, and preventddproffrom analyzing past the Go boundary, but this seems difficult to achieve and I'm not sure the Rust portion will really benefit from tracing yet.This also renames
GO_LOG_ALLtoGO_LOGwhich now takes a log level, so can be configured similar toRUST_LOGwithGO_LOG=info