Fortuna CI workflows #1120
Merged
Fortuna CI workflows #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
jayantk
commented
Oct 20, 2023
| toolchain: nightly-2023-07-23 | ||
| override: true | ||
| - name: Run executor tests | ||
| run: cargo test --manifest-path ./fortuna/Cargo.toml |
There was a problem hiding this comment.
there aren't any unit tests right now, but this checks the build and will run the tests once we add some
jayantk
commented
Oct 20, 2023
| @@ -77,6 +77,7 @@ import "./PythRandomEvents.sol"; | |||
| // - gas optimizations | |||
| // - function to check invariants?? | |||
| // - need to increment pyth fees if someone transfers funds to the contract via another method | |||
| // - off-chain data ERC support? | |||
There was a problem hiding this comment.
drive by so we remember
ali-bahjati
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CI workflows to bulid/test and publish a docker image
turns out the last PR had some build failures so I fixed those too