[fortuna] Support multiple random value encodings #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
jayantk
commented
Nov 1, 2023
| } | ||
| } | ||
|
|
||
| pub fn data(&self) -> &[u8; 32] { |
There was a problem hiding this comment.
i don't love that i need to write all this code here to specify that every variant has the same data field -- is there a better way to do this?
Reisen
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the API design guidelines, add support for multiple binary encodings to fortuna. This PR makes the endpoint take a
?encoding=query parameter. Binary values are returned as a json object of the form:{ encoding: "hex", data: "123ab" }(this is a nice-to-have, but I think it's going to save us a lot of questions from users of the form "how do i convert this array to a hex string")