[entropy] Change provider interface to simplify supporting many chains #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
jayantk
commented
Nov 25, 2023
| @@ -186,7 +186,6 @@ contract Entropy is IEntropy, EntropyState { | |||
| req.providerCommitment = providerInfo.currentCommitment; | |||
| req.providerCommitmentSequenceNumber = providerInfo | |||
| .currentCommitmentSequenceNumber; | |||
| req.providerCommitmentMetadata = providerInfo.commitmentMetadata; | |||
There was a problem hiding this comment.
drive by: I deleted this field from req (it's not needed)
jayantk
commented
Nov 25, 2023
| @@ -44,19 +44,14 @@ contract EntropyTest is Test { | |||
| random.register( | |||
| provider1FeeInWei, | |||
| provider1Proofs[0], | |||
| bytes32(keccak256(abi.encodePacked(uint256(0x0100)))), | |||
| hex"0100", | |||
There was a problem hiding this comment.
drive-by: shorter way to write this
ali-bahjati
reviewed
Nov 26, 2023
| chain_id: &ChainId, | ||
| random: [u8; 32], | ||
| random: &[u8; 32], |
There was a problem hiding this comment.
I think seed is a better name here.
ali-bahjati
reviewed
Nov 26, 2023
| @@ -1,45 +1,4 @@ | |||
| [ | |||
| { | |||
There was a problem hiding this comment.
Why these got deleted? :?
ali-bahjati
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Entropy contract has a single
bytes32field that providers can use to store arbitrary metadata associated with their hash chain. We're using this to store a random seed that the provider can use to regenerate the chain. However, the chain on the server is a function of both the random seed and a chain length parameter (and also a secret which of course isn't on the blockchain). Thus, at the moment, every blockchain must use the exact same chain length. This is brittle and will cause operational problems down the line when we need to manage different chains on many different chains.This PR changes the field to be
bytesand the providers can choose to store however much data they want in there. I also changed fortuna to store both the secret and the chain length.