fix: minor fixes #2166
Merged
fix: minor fixes #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
guibescos
commented
Dec 4, 2024
•
guibescos
commented
- set minimum publishers in proposal after changing publisher set
- fix proposals time
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
cprussin
approved these changes
Dec 4, 2024
| if (firstBlockTime) { | ||
| setTime(new Date(firstBlockTime * 1000)) | ||
| } | ||
| }) |
There was a problem hiding this comment.
We should probably add a catch, even if it's just to log -- generally you should include a catch any time you use a promise without async/await, otherwise uncaught async errors can put the application in a bad state but be very hard to debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.