fix Worker redis_settings error

python-arq · Mar 12, 2019 · 9848edd · 9848edd
1 parent 183ce56
commit 9848edd
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -3,6 +3,10 @@
 History
 -------
 
+v0.16.0a3 (2010-03-12)
+......................
+* fix ``Worker`` with custom redis settings
+
 v0.16.0a2 (2010-03-06)
 ......................
 * add ``job_try`` argument to ``enqueue_job``, #113

diff --git a/arq/connections.py b/arq/connections.py
@@ -140,7 +140,9 @@ async def create_pool(settings: RedisSettings = None, *, _retry: int = 0) -> Arq
     except (ConnectionError, OSError, aioredis.RedisError, asyncio.TimeoutError) as e:
         if _retry < settings.conn_retries:
             logger.warning(
-                'redis connection error %s %s, %d retries remaining...',
+                'redis connection error %s:%s %s %s, %d retries remaining...',
+                settings.host,
+                settings.port,
                 e.__class__.__name__,
                 e,
                 settings.conn_retries - _retry,

diff --git a/arq/version.py b/arq/version.py
@@ -2,4 +2,4 @@
 
 __all__ = ['VERSION']
 
-VERSION = StrictVersion('0.16a2')
+VERSION = StrictVersion('0.16a3')
diff --git a/arq/worker.py b/arq/worker.py
@@ -156,9 +156,9 @@ def __init__(
         self.health_check_interval = to_seconds(health_check_interval)
         self.pool = redis_pool
         if self.pool is None:
-            self.redis_settings = None
-        else:
             self.redis_settings = redis_settings or RedisSettings()
+        else:
+            self.redis_settings = None
         self.tasks = []
         self.main_task = None
         self.loop = asyncio.get_event_loop()