Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flake8 >= 5 regex failure #34

Closed
wants to merge 1 commit into from
Closed

Fix flake8 >= 5 regex failure #34

wants to merge 1 commit into from

Conversation

nth10sd
Copy link

@nth10sd nth10sd commented Jan 4, 2023

Fix #32 - the reason for this is because SLOT does not match the regex ^[A-Z]{1,3}[0-9]{0,3}$ that is now present from flake8 version 5 onwards.

SLO is used instead. Please let me know if another one is preferred. flake8 --version or flake8 . now works with this change.

@auto-assign auto-assign bot requested a review from domdfcoding January 4, 2023 00:22
@nth10sd
Copy link
Author

nth10sd commented Jan 20, 2023

@domdfcoding ping - any thoughts?

@stale stale bot added the stale label Jul 19, 2023
@nth10sd
Copy link
Author

nth10sd commented Aug 19, 2023

Sorry, I'm no longer using this tool.

@nth10sd nth10sd closed this Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domdfcoding domdfcoding Awaiting requested review from domdfcoding

Assignees

@domdfcoding domdfcoding

Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake8-slots does not seem to work with flake8 5
2 participants
@nth10sd @domdfcoding