Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to run with Alembic with FastAPI #5

Open
nf1s opened this issue Jul 17, 2020 · 4 comments
Open

Failing to run with Alembic with FastAPI #5

nf1s opened this issue Jul 17, 2020 · 4 comments

Comments

@nf1s
Copy link

nf1s commented Jul 17, 2020

Expected Behavior

I am trying to run the alembic make migrations and expected to succeed

Actual Behavior

exception is raised

Steps to Reproduce the Problem

  1. clone https://github.com/ahmednafies/fastapi_gino.git
  2. run make makemigrations
command
`alembic revision --autogenerate`

error
AttributeError: type object 'AsyncpgDBAPI' has no attribute 'connect'

Specifications

  • Python version: 3.8.3
  • GINO version: 1.0.1
  • Starlette version: 0.13.4
@nf1s nf1s changed the title Faling to run with Alembic with FastAPI Failing to run with Alembic with FastAPI Jul 17, 2020
@nf1s
Copy link
Author

nf1s commented Jul 20, 2020

@fantix: what do you think?

@fantix
Copy link
Member

fantix commented Sep 7, 2020

Did you fix this? I cannot reproduce:

fastapi_gino$ pipenv run alembic revision --autogenerate
Loading .env environment variables…
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
INFO  [alembic.autogenerate.compare] Detected added table 'users'
INFO  [alembic.autogenerate.compare] Detected added index 'ix_users_id' on '['id']'
  Generating /private/tmp/fastapi_gino/alembic/versions/bed5859fd0ca_.py ...  done

fastapi_gino$ pipenv run make migrate
Loading .env environment variables…
alembic upgrade head
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
INFO  [alembic.runtime.migration] Running upgrade  -> bed5859fd0ca, empty message

@nf1s
Copy link
Author

nf1s commented Sep 14, 2020

Still I have the same error.

@Chaostheorie
Copy link
Contributor

Well this is stale. But I haven't been able to reproduce either, with the newest versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants