Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganize compressible riemann solver interface to prepare for SphericalPolar geometry #210

Merged
merged 7 commits into from
Aug 29, 2024

Conversation

zhichen3
Copy link
Collaborator

  1. Split up riemann_cgf to 2 parts: getting the conserved states then flux construction
  2. added an overall riemann_flux interface to find the flux directly if there is no need to get the conserved states.
  3. make consFlux general for both multi-zone U_state or single zone U_state.

idens, ixmom, iymom, iener, irhoX, nspec,
lower_solid, upper_solid,
gamma, U_l, U_r):
def riemann_cons(idir, ng,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this should still be named CGF, since this is the Colella, Glaz, Fergoson solver. We will add more solvers and want to keep them straight.

Then you new wrapper can be used to get the flux as needed by calling the appropriate solver.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now riemann_flux is the general interface to directly get flux from riemann solvers given direction. And riemann_cgf now gives conserved states.

@zingale zingale merged commit 1cdab61 into python-hydro:main Aug 29, 2024
12 checks passed
@zingale
Copy link
Collaborator

zingale commented Aug 29, 2024

this is very nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants