Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove _*.defaults for problems and use a dict instead #255

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

zingale
Copy link
Collaborator

@zingale zingale commented Sep 5, 2024

Now the problem parameters are specified in a dict in the problem's python module, instead of separately in a file that needs to be parsed. This will make it easier to define a new problem completely in Jupyter, since we can just create the dict on our own.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@zingale zingale merged commit 9c65825 into python-hydro:main Sep 6, 2024
13 checks passed
@zingale zingale deleted the prob_params branch September 6, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant