-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase/Decrease status code ranges #134
Comments
Given this observation... #95 (comment) I think it'd be a fair change to expand the allowed range to support non-conforming XXX values. $ curl --http1.1 --head https://www.linkedin.com/company/linkedin
HTTP/1.1 999 Request denied
Cache-Control: no-cache, no-store
Pragma: no-cache
Content-Length: 1529
Content-Type: text/html
Expires: Thu, 01 Jan 1970 00:00:00 GMT
Set-Cookie: trkCode=bf; Max-Age=5
Set-Cookie: trkInfo=AQEQu_fWUsOvWQAAAXsbrvEY6x_26G7cumSaPiDWve6_jGqzHEXzwMY8OZ8ZS_cqymL_WdCFz_hWkw_cEkQnGzBHcuZshMBT6Qpb71ALo51X26uz4ME_ik9uaysDlHsksXp9QU8=; Max-Age=5
Set-Cookie: rtc=AQGWPBJ4fVNkmQAAAXsbrvEYHs6svtFHGKh-_F7jCpvN1TMs49bCzdDAUjYVFSNwm9qFzLcGt6rISQDzO7RrTpq3VDKxvTBOKCU6Ed0UCY6A8juKSwg6xpA_nfn2s9eKKwAkoaamrh-at6PNEKKEsRAlHBMVQaLFpmkbFjI_w2EcIlM9nw5inH2Smq963e0qruVHMdYhG_qjKXgG; Max-Age=120; path=/; domain=.linkedin.com
X-Li-Fabric: prod-lor1
X-Li-Pop: afd-prod-lor1
X-Li-Proto: http/1.1
X-LI-UUID: tYdxOCq7mBaAQANv8ioAAA==
X-Cache: CONFIG_NOCACHE
X-MSEdge-Ref: Ref A: FFE6F8566CE84CBEA5FC515947EE7836 Ref B: LON04EDGE1114 Ref C: 2021-08-06T13:37:35Z
Date: Fri, 06 Aug 2021 13:37:35 GMT Granted the server is non-conforming here, but it's a big-name site, and we need to be robust to in the wild behaviours, right? I can't take a call on this for any other maintainers point of view, but if anyone's keen on putting together a pull request for this I think it'd be worth a go. |
Hi all, I'm wondering if at least we can include status code 100 because I'm not too sure how else to handle an This is part of the http1.1 protocol [1] as far as I understand it, so do you think it's valid to add it? Edit: Any opinions/suggestions? Thanks! [1] https://www.w3.org/Protocols/rfc2616/rfc2616-sec8.html#sec8.2.3 |
Bumping this issue - would like to see support for 100 - 199 codes. |
@tyteen4a03 As far as I know, h11 has always had full support for 100-199 status codes. What are you missing? |
When trying to create a response with 100 status, I get |
@tyteen4a03 ah, that's because h11 models 1xx status codes as |
Thank you for all the development.
I have seen in h11/h11/_events.py / the handled status codes ranges are between
[200, 600)
.As this is the standard to follow, it's great to have it, but there are some http servers that don't follow the standard. What you think about adding the possibility to setup the status code ranges or increasing them for possible exceptional cases?
The text was updated successfully, but these errors were encountered: