Skip to content

Commit

Permalink
chore: Set permissions for GitHub actions
Browse files Browse the repository at this point in the history
 Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.

- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)

Signed-off-by: neilnaveen <[email protected]>
  • Loading branch information
neilnaveen committed Jul 4, 2022
1 parent 26e2c7e commit 43b185e
Show file tree
Hide file tree
Showing 9 changed files with 37 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: Lint

on: [push, pull_request, workflow_dispatch]

permissions:
contents: read

jobs:
build:

Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/release-drafter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,14 @@ on:
- main
workflow_dispatch:

permissions:
contents: read

jobs:
update_release_draft:
permissions:
contents: write # for release-drafter/release-drafter to create a github release
pull-requests: write # for release-drafter/release-drafter to add label to PR
if: github.repository == 'python-pillow/Pillow'
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test-cygwin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ jobs:
name: Cygwin Python 3.${{ matrix.python-minor-version }}

success:
permissions:
contents: none
needs: build
runs-on: ubuntu-latest
name: Cygwin Test Successful
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/test-docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: Test Docker

on: [push, pull_request, workflow_dispatch]

permissions:
contents: read

jobs:
build:

Expand Down Expand Up @@ -82,6 +85,8 @@ jobs:
name: ${{ matrix.docker }}

success:
permissions:
contents: none
needs: build
runs-on: ubuntu-latest
name: Docker Test Successful
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/test-mingw.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: Test MinGW

on: [push, pull_request, workflow_dispatch]

permissions:
contents: read

jobs:
build:
runs-on: windows-latest
Expand Down Expand Up @@ -77,6 +80,8 @@ jobs:
CODECOV_NAME: ${{ matrix.name }}

success:
permissions:
contents: none
needs: build
runs-on: ubuntu-latest
name: MinGW Test Successful
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/test-valgrind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ on:
- "**.h"
workflow_dispatch:

permissions:
contents: read

jobs:
build:

Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/test-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: Test Windows

on: [push, pull_request, workflow_dispatch]

permissions:
contents: read

jobs:
build:
runs-on: windows-latest
Expand Down Expand Up @@ -189,6 +192,8 @@ jobs:
path: dist\*.whl

success:
permissions:
contents: none
needs: build
runs-on: ubuntu-latest
name: Windows Test Successful
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: Test

on: [push, pull_request, workflow_dispatch]

permissions:
contents: read

jobs:
build:

Expand Down Expand Up @@ -109,6 +112,8 @@ jobs:
CODECOV_NAME: ${{ matrix.os }} Python ${{ matrix.python-version }}

success:
permissions:
contents: none
needs: build
runs-on: ubuntu-latest
name: Test Successful
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/tidelift.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ on:
- ".github/workflows/tidelift.yml"
workflow_dispatch:

permissions:
contents: read

jobs:
build:
if: github.repository_owner == 'python-pillow'
Expand Down

0 comments on commit 43b185e

Please sign in to comment.