Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix use of grayscale/greyscale in document and code #7479

Closed
wx00 opened this issue Oct 19, 2023 · 1 comment · Fixed by #7481
Closed

Mix use of grayscale/greyscale in document and code #7479

wx00 opened this issue Oct 19, 2023 · 1 comment · Fixed by #7481

Comments

@wx00
Copy link
Contributor

wx00 commented Oct 19, 2023

What did you do?

I've been searching in the document and found it use "grayscale" in some places and "greyscale" in some other places, describing same type of images in Pillow. I also viewed those parts of code and found out they are mostly consistent with corresponding documents.

What did you expect to happen?

It should be using the same word across the whole document and code.

What actually happened?

Mix use of slightly different spelling words across multiple places.

What are your OS, Python and Pillow versions?

Not related to the issue. The mix use of both words seems to have been the case for a very long time, at least since Pillow 3.x, which makes me a bit confused.

Examples

Examples of grayscale:

Examples of greyscale:

@radarhere
Copy link
Member

Using grep, I find that 'gray' is more popular in the codebase. I've created #7481 to use 'gray'.

However, I have left ImImagePlugin alone, as it actually writes "Greyscale" into image files.

SAVE = {
# mode: (im type, raw mode)
"1": ("0 1", "1"),
"L": ("Greyscale", "L"),
"LA": ("LA", "LA;L"),
"P": ("Greyscale", "P"),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants