Expose git errors instead of printing a generic error message #9845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
the testcase you have added passes already without your fix |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
abn
reviewed
Nov 15, 2024
| " for this repository." | ||
| ) | ||
| except CalledProcessError as e: | ||
| raise PoetryConsoleError(f"Failed to clone {url}\n {e.stderr}") |
There was a problem hiding this comment.
I would suggest the git error be surfaced via logger.debug instead. The proposed change is too noisy.
Suggested change
| raise PoetryConsoleError(f"Failed to clone {url}\n {e.stderr}") | |
| logger.debug("Git command returned the following error:\n%s", e.stderr) | |
| raise PoetryConsoleError( | |
| f"Failed to clone {url}, check your git configuration and permissions" | |
| " for this repository." | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #9819