Add trio.hazmat.batch_cancellations() #900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #900 +/- ##
==========================================
- Coverage 99.53% 99.32% -0.21%
==========================================
Files 102 102
Lines 12411 12461 +50
Branches 916 918 +2
==========================================
+ Hits 12353 12377 +24
- Misses 36 60 +24
- Partials 22 24 +2
|
This generalizes the "cancel multiple scopes without waking up the tasks, then wake up all the tasks at once" pattern that was previously a special case for handling cancellations on a deadline. It will simplify the implementation of python-trio#886, and exposing it as part of hazmat lets users write their own cancellation abstractions that work the way the native ones do.
|
What do you think of #860 as a way to eliminate the need for this entirely? |
|
I had looked at that, and I agree that it would be cleaner if we can get it to work, but I'm leery of lurking bugs if the cancellation landscape changes in just the wrong way while a |
|
We decided #860 works after all, so let's go with that instead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes the "cancel multiple scopes without waking up the tasks, then wake up all the tasks at once" pattern that was previously a special case for handling cancellations on a deadline. It will simplify the
implementation of #886, and exposing it as part of hazmat lets users write their own cancellation
abstractions that work the way the native ones do.