Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username detection fails with a trailing slash #109

Closed
AA-Turner opened this issue Jan 20, 2024 · 0 comments · Fixed by #110
Closed

Username detection fails with a trailing slash #109

AA-Turner opened this issue Jan 20, 2024 · 0 comments · Fixed by #110

Comments

@AA-Turner
Copy link
Member

I have my remote origin set to https://github.com/AA-Turner/cpython/.

PS> git remote -v
origin  https://github.com/AA-Turner/cpython/ (fetch)
origin  https://github.com/AA-Turner/cpython/ (push)
upstream        https://github.com/python/cpython/ (fetch)
upstream        https://github.com/python/cpython/ (push)

cherry_picker runs git config --get remote.origin.url, which returns the above url, and then runs username = result.replace(":", "/").split("/")[-2]. This returns cpython, which means that I have to manually edit the URL on every backport.

cherry_picker should instead trim any trailing slash.

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant