Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] Complete dropping support for Python 3.8 #136

Closed
webknjaz opened this issue Oct 11, 2024 · 5 comments · Fixed by #137
Closed

[TODO] Complete dropping support for Python 3.8 #136

webknjaz opened this issue Oct 11, 2024 · 5 comments · Fixed by #137
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@webknjaz
Copy link
Contributor

#133 did this for CI already, but there are two pieces of the metadata that still advertise 3.8: Require-Python and Trove classifiers.

@hugovk
Copy link
Member

hugovk commented Oct 11, 2024

Thanks, would you like to open a PR?

@webknjaz
Copy link
Contributor Author

I think it's a good first issue so I'll let someone else do that.

@hugovk hugovk added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 11, 2024
@webknjaz
Copy link
Contributor Author

@hugovk perhaps add the hacktoberfest labels to the issue and the repo?

@hugovk
Copy link
Member

hugovk commented Oct 11, 2024

Sure! Issue labelled. I don't have permission to add topics to the repo, but can add hacktoberfest-accepted to a PR.

@webknjaz
Copy link
Contributor Author

@hugovk ack. @OlenaYefymenko will make the PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants