-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change CLA bot link from the-knights-who-say-ni
to ambv/cla-bot
#469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps add the new CLA bot to the list?
I wasn't sure which to add. https://github.com/apps/cpython-cla-bot doesn't tell you which repository it's working from. It seems like it is https://github.com/ambv/cla-bot but I also saw posts about that repo being moved to the |
Yeah, it's at https://github.com/ambv/cla-bot. I don't know when it's being moved, but when it is, the old link should redirect to the new location. |
the-knights-who-say-ni
from list of tools in READMEthe-knights-who-say-ni
to amber/cla-bot
the-knights-who-say-ni
to amber/cla-bot
the-knights-who-say-ni
to ambv/cla-bot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
`python/the-knights-who-say-ni`_ CLA enforcement bot for `GitHub <https://github.com/ `Brett Cannon`_ | ||
Python organization python/the-knights-who-say-ni/issues>`__ | ||
`ambv/cla-bot`_ CLA enforcement bot for `Łukasz Langa`_ | ||
Python organization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the "Issue tracker" column you could add the upstream link (https://github.com/edgedb/cla-bot/issues) or a link to this repo (https://github.com/python/core-workflow/issues). @ambv, do you have any opinion on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will move ambv/cla-bot under python/cla-bot when I'm back from my July travels. I'm at EuroPython right now, are you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately not. Do you want to wait until the bot is moved to update and merge this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge as-is and then update once it's moved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged this and created #470 as a reminder for the update.
Since this tool is archived and no longer used I don't think it should be in the README anymore.