Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CLA bot link from the-knights-who-say-ni to ambv/cla-bot #469

Merged
merged 4 commits into from
Jul 13, 2022
Merged

Change CLA bot link from the-knights-who-say-ni to ambv/cla-bot #469

merged 4 commits into from
Jul 13, 2022

Conversation

DanielNoord
Copy link
Contributor

Since this tool is archived and no longer used I don't think it should be in the README anymore.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add the new CLA bot to the list?

@DanielNoord
Copy link
Contributor Author

DanielNoord commented Jul 8, 2022

Perhaps add the new CLA bot to the list?

I wasn't sure which to add.

https://github.com/apps/cpython-cla-bot doesn't tell you which repository it's working from. It seems like it is https://github.com/ambv/cla-bot but I also saw posts about that repo being moved to the python org... Not sure where to link to at the moment.

@hugovk
Copy link
Member

hugovk commented Jul 8, 2022

Yeah, it's at https://github.com/ambv/cla-bot.

I don't know when it's being moved, but when it is, the old link should redirect to the new location.

README.rst Outdated Show resolved Hide resolved
@DanielNoord DanielNoord changed the title Remove the-knights-who-say-ni from list of tools in README Change CLA bot link from the-knights-who-say-ni to amber/cla-bot Jul 8, 2022
@DanielNoord DanielNoord changed the title Change CLA bot link from the-knights-who-say-ni to amber/cla-bot Change CLA bot link from the-knights-who-say-ni to ambv/cla-bot Jul 8, 2022
@DanielNoord DanielNoord requested a review from hugovk July 8, 2022 10:31
README.rst Outdated Show resolved Hide resolved
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

`python/the-knights-who-say-ni`_ CLA enforcement bot for `GitHub <https://github.com/ `Brett Cannon`_
Python organization python/the-knights-who-say-ni/issues>`__
`ambv/cla-bot`_ CLA enforcement bot for `Łukasz Langa`_
Python organization
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "Issue tracker" column you could add the upstream link (https://github.com/edgedb/cla-bot/issues) or a link to this repo (https://github.com/python/core-workflow/issues). @ambv, do you have any opinion on this?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will move ambv/cla-bot under python/cla-bot when I'm back from my July travels. I'm at EuroPython right now, are you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not. Do you want to wait until the bot is moved to update and merge this?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge as-is and then update once it's moved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged this and created #470 as a reminder for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants