Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make condition inside codegen_addop_load_const a macro #129552

Closed
WolframAlph opened this issue Feb 1, 2025 · 2 comments
Closed

Make condition inside codegen_addop_load_const a macro #129552

WolframAlph opened this issue Feb 1, 2025 · 2 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@WolframAlph
Copy link
Contributor

WolframAlph commented Feb 1, 2025

Bug report

Bug description:

We need to reuse this condition:

if (!overflow && val >= 0 && val < 256 && val < _PY_NSMALLPOSINTS) {

in CFG. FTR: #129568 (comment).

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

@WolframAlph WolframAlph added the type-bug An unexpected behavior, bug, or error label Feb 1, 2025
@picnixz picnixz added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Feb 1, 2025
@WolframAlph WolframAlph changed the title Redundant condition inside codegen_addop_load_const Make condition inside codegen_addop_load_const a macro Feb 3, 2025
@WolframAlph
Copy link
Contributor Author

WolframAlph commented Feb 3, 2025

@picnixz , can you edit bug label, since this issue has changed?

@WolframAlph
Copy link
Contributor Author

Closing as this will be done as part of another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants