Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.10: GHA Docs builds of PRs fail because they use removed actions/upload-artifact: v3 #129641

Open
encukou opened this issue Feb 4, 2025 · 1 comment
Open

3.10: GHA Docs builds of PRs fail because they use removed actions/upload-artifact: v3 #129641

encukou opened this issue Feb 4, 2025 · 1 comment
Labels
3.9 only security fixes 3.10 only security fixes infra CI, GitHub Actions, buildbots, Dependabot, etc. type-bug An unexpected behavior, bug, or error

Comments

@encukou
Copy link
Member

encukou commented Feb 4, 2025 •
edited by bedevere-app bot
Loading

3.10 & 3.9 PRs fail on documentation builds with:

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

For example: https://github.com/python/cpython/actions/runs/13077929192/job/36494533879?pr=129529

Linked PRs
@encukou encukou added 3.10 only security fixes 3.9 only security fixes infra CI, GitHub Actions, buildbots, Dependabot, etc. labels Feb 4, 2025
@encukou encukou mentioned this issue Feb 4, 2025
Open
@picnixz picnixz added the type-bug An unexpected behavior, bug, or error label Feb 4, 2025
@encukou
Copy link
Member Author

encukou commented Feb 4, 2025

Note that for newer branches, docs builds were switched to Netlify (in #100330) and then Read the Docs; we no longer use upload-artifact there.
3.10 and 3.9 have a stub Read the Docs config file that disables the builds there (which currently fails, see #129509).

encukou added a commit to encukou/cpython that referenced this issue Feb 4, 2025
@encukou
[3.10] pythongh-129641: Switch Docs GHA build to actions/upload-artif…
e951843 
…act@v4

Add options for backwards compatibility, from the docs at:
https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes
@bedevere-app bedevere-app bot mentioned this issue Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.9 only security fixes 3.10 only security fixes infra CI, GitHub Actions, buildbots, Dependabot, etc. type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@encukou @picnixz