Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meeting note from Feb 2024 #106
Add meeting note from Feb 2024 #106
Changes from 5 commits
9e0d69f
f3bfb59
53be5d3
3ab37ef
dc68872
ab631d5
9f08369
c0b9c2b
f4da79c
fb01034
e36c7d4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part seems a bit jumbled together (not sure if the conversation was, or if the discussion was transcribed out of order).
First of all it's missing some context, such as the problems that collapsible sections, such as that they don't work with different builders. I would put this near the top, since the whole discussion becomes moot if we don't use them.
Regarding page length (and specifically examples length, if counted with something smarter than a
wc -l
), the script could be used both for pages with not enough examples (so we should add more), and pages that have too many (they might be better moved to the "Examples" section or a separate page).I would close with Carol's summary.
P.S. I'm not sure if @nedbat suggested having a page for each function, I think it was @hugovk to bring this up while talking about PHP docs, but I might be misremembering.