Skip to content

Remove function from builtins #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidhalter opened this issue May 19, 2019 · 3 comments
Closed

Remove function from builtins #2999

davidhalter opened this issue May 19, 2019 · 3 comments

Comments

@davidhalter
Copy link
Contributor

There's a class function in builtins.pyi. There's also a mention to remove it: # TODO not defined in builtins!. I feel like this was probably created for mypy? As an alternative I would suggest using types.pyi's FunctionType.

I personally have to patch typeshed to remove this for Jedi. Why is this there and is it still needed? I'm happy to create a PR for this.

@davidhalter
Copy link
Contributor Author

These are the test results for mypy if you try to remove it: https://travis-ci.org/davidhalter/typeshed/jobs/534417186. I'm still in favor of removing it. mypy is by far not the only software using typeshed.

@JelleZijlstra
Copy link
Member

JelleZijlstra commented May 19, 2019

mypy is by far not the only software using typeshed.

But it is among the most important users. We're not going to just break one of our most important current users.

There is an existing issue for this in mypy: python/mypy#3171. That issue will have to be addressed first before we can remove it from typeshed.

@AlexWaygood
Copy link
Member

Closing as we now have #7580, and I don't think we need both issues to be open when they're about the same thing

@AlexWaygood AlexWaygood closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants