Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Camera Shake 2D with feature requested in #2429 #2448

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

DragonMoffon
Copy link
Collaborator

Thank you, @bunny-therapist, for the feature request!

Also adds the context manager interface, allowing for the following neat code:

with self.shake, self.camera.activate():
  # draw commands that want to be drawn with screen shake,
# outside of the with block the shake has been removed, and the camera has been deactivated.

closes #2429 and #2446 (Thank you for the PR, but due to the extra feature I've made my own PR)

@DragonMoffon DragonMoffon changed the title Update Camera Shake 2D with feature requested in #2429 Update Camera Shake 2D with feature requested from #2429 Nov 13, 2024
@DragonMoffon DragonMoffon changed the title Update Camera Shake 2D with feature requested from #2429 Update Camera Shake 2D with feature requested in #2429 Nov 13, 2024
@DragonMoffon DragonMoffon merged commit 575d662 into development Nov 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add direction to ScreenShake2D
1 participant