-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A Horrible mistake! #26
Comments
does this affect multiprocess training though? i couldn't see any reset in multiprocess env. |
I didn't check that environment. |
by having this sentence in mind you might find the bug: "I noticed that you are reseting the env at the beginning of each episode!" |
Thanks. I'm not the repo owner though. I'm just a learner. By the way, could you suggest me some repos/tutorials for reinforcement or deep learning for cryptocurrency trading? |
not really. I do not. |
Hello, this repo was not updated for 4 years, it is outdated and might be issues, bugs and etc. I recommend to switch to my later similar implementation: https://github.com/pythonlessons/FinRock |
I noticed that you are reseting the env at the beginning of each episode!
By doing this you never go forward in your dataset!
check train_agent function.
Thats why you train your model for 50000 episodes and nothing goes wrong!! (all your database is smaller than 50000. it is 23450)
The text was updated successfully, but these errors were encountered: