Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Horrible mistake! #26

Open
kianfa opened this issue Apr 10, 2024 · 6 comments
Open

A Horrible mistake! #26

kianfa opened this issue Apr 10, 2024 · 6 comments

Comments

@kianfa
Copy link

kianfa commented Apr 10, 2024

I noticed that you are reseting the env at the beginning of each episode!

By doing this you never go forward in your dataset!

check train_agent function.

Thats why you train your model for 50000 episodes and nothing goes wrong!! (all your database is smaller than 50000. it is 23450)

@manigot
Copy link

manigot commented Jun 26, 2024

does this affect multiprocess training though? i couldn't see any reset in multiprocess env.

@kianfa
Copy link
Author

kianfa commented Jun 26, 2024

I didn't check that environment.
but your env at part 4 has this problem for sure.
I hardly remember what was wrong exactly. It was a long time ago. However, you might find something by searching "reset(" in your code. I believe you had called this function in your loop!

@kianfa
Copy link
Author

kianfa commented Jun 26, 2024

by having this sentence in mind you might find the bug:

"I noticed that you are reseting the env at the beginning of each episode!"

@manigot
Copy link

manigot commented Jun 26, 2024

Thanks. I'm not the repo owner though. I'm just a learner. By the way, could you suggest me some repos/tutorials for reinforcement or deep learning for cryptocurrency trading?

@kianfa
Copy link
Author

kianfa commented Jun 26, 2024

not really. I do not.
this is a complex world!
I would continue this adventure for next few years. Maybe we can stay in touch. email me directly.

@pythonlessons
Copy link
Owner

Hello, this repo was not updated for 4 years, it is outdated and might be issues, bugs and etc. I recommend to switch to my later similar implementation: https://github.com/pythonlessons/FinRock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants