None: Replace the Tensor Layer name from "Unnamed Layer #" to its original name #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: api [Python]
gs-olive
reviewed
Oct 10, 2023
Comment on lines
+155
to
+160
| identity_layer.metadata = f"[{identity_layer.type.name}]-[{target_name}]-[{name}]-[#_of_outputs_{identity_layer.num_outputs}]" | ||
|
|
||
| for i in range(identity_layer.num_outputs): | ||
| output = identity_layer.get_output(i) | ||
| output.name = f"[{output.name}]" | ||
|
|
There was a problem hiding this comment.
Could you remove this code from the cast_trt_tensor function, and make a new function in this file which is an exact copy of set_layer_name from fx/, with your change added?
There was a problem hiding this comment.
Afterward, could you search the directory dynamo/conversion/ for any uses of set_layer_name and switch the import to use your new implementation, instead of the legacy fx version?
Comment on lines
+126
to
+130
| layer.metadata = f"[{layer.type.name}]-[{target_name}]-[{name}]-[#_of_outputs_{layer.num_outputs}]" | ||
|
|
||
| for i in range(layer.num_outputs): | ||
| output = layer.get_output(i) | ||
| output.name = f"[{output.name}]" |
There was a problem hiding this comment.
Remove this change from the fx/ directory, since the contribution should be strictly to Dynamo
|
Closing this PR since there are updates to cast and identity layer. Please rebase and reopen incase these changes are still valid. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close the previous MR due to the long rebase changes from main after 2 weeks.
Replace the Tensor Layer name from "Unnamed Layer #" to its original name
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: