New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SAM2 to TorchBench model set #2566

Open

huydhn opened this issue Jan 16, 2025 · 2 comments

Assignees

Contributor

huydhn commented Jan 16, 2025

We want to add SAM2 from https://github.com/facebookresearch/sam2?tab=readme-ov-file#download-checkpoints to TorchBench so that it can be included as part of PT2 OSS benchmark run.

cc @kit1980 Let's take this opportunity to follow @xuzhao9 documentation in https://github.com/pytorch/benchmark/blob/main/torchbenchmark/models/ADDING_MODELS.md to add the model.

huydhn added this to PyTorch OSS Dev Infra

huydhn self-assigned this

Contributor

cpuhrsch commented Jan 16, 2025

cc @josephgreer

Contributor

cpuhrsch commented Jan 16, 2025 •

edited

Loading

In particular we'd need the backbone models with the various configurations checkpoints loaded via

https://github.com/pytorch/ao/blob/522f5b854a278ee9e68e80bf8213e19c9da4e547/examples/sam2_amg_server/server.py#L472-L480

It's sufficient to use the resulting model for a particular task to exercise this. For example https://github.com/pytorch/ao/blob/522f5b854a278ee9e68e80bf8213e19c9da4e547/examples/sam2_amg_server/server.py#L294 on some example shape such as https://github.com/pytorch/ao/blob/522f5b854a278ee9e68e80bf8213e19c9da4e547/examples/sam2_amg_server/server.py#L63 after instantiating an instance via
https://github.com/pytorch/ao/blob/522f5b854a278ee9e68e80bf8213e19c9da4e547/examples/sam2_amg_server/server.py#L478-L480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment