Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] allow both get_ic_generator and batch_initial_conditions to be used in the same call. #2609

Open
CompRhys opened this issue Nov 1, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@CompRhys
Copy link
Contributor

CompRhys commented Nov 1, 2024

🚀 Feature Request

When targeting a campaign I might want to include some points explicitly and then fill up the rest of the initial candidates using the strategies in botorch. This behaviour would be triggered by having n_repeats > len(batch_initial_conditions)

Motivation

Makes it much easier to do facebook/Ax#2938 as then all I have to worry about to get the desired behaviour for that to get merged is dropping the points from the given X_pareto front that do not satisfy the constraints

Pitch

this should be fairly minimal change in the logic to check that raw_samples is not None and then just using raw_samples-len(batch_initial_conditions) as the number of requested samples to the ic generator.

Are you willing to open a pull request? (See CONTRIBUTING)

yes

Additional context

@CompRhys CompRhys added the enhancement New feature or request label Nov 1, 2024
@saitcakmak
Copy link
Contributor

Hi @CompRhys! That sounds reasonable to me. Happy to review a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants