Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Versioning] Fix moviepy 2.0 incompatibility #2594

Merged
merged 1 commit into from
Nov 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/unittest/linux/scripts/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dependencies:
- future
- cloudpickle
- pygame
- moviepy
- moviepy<2.0.0
- tqdm
- pytest
- pytest-cov
Expand Down
2 changes: 1 addition & 1 deletion .github/unittest/linux_distributed/scripts/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dependencies:
- future
- cloudpickle
- pygame
- moviepy
- moviepy<2.0.0
- tqdm
- pytest
- pytest-cov
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dependencies:
- future
- cloudpickle
- pygame
- moviepy
- moviepy<2.0.0
- pytest-cov
- pytest-mock
- pytest-instafail
Expand Down
2 changes: 1 addition & 1 deletion .github/unittest/linux_libs/scripts_gym/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dependencies:
- future
- cloudpickle
- pygame
- moviepy
- moviepy<2.0.0
- tqdm
- pytest
- pytest-cov
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dependencies:
- future
- cloudpickle
- pygame
- moviepy
- moviepy<2.0.0
- tqdm
- pytest
- pytest-cov
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dependencies:
- cloudpickle
- gym[atari]==0.13
- pygame
- moviepy
- moviepy<2.0.0
- tqdm
- pytest
- pytest-cov
Expand Down
2 changes: 1 addition & 1 deletion .github/unittest/linux_sota/scripts/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dependencies:
- future
- cloudpickle
- pygame
- moviepy
- moviepy<2.0.0
- tqdm
- pytest
- pytest-cov
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,7 @@ make of torchrl:
pip3 install tqdm tensorboard "hydra-core>=1.1" hydra-submitit-launcher

# rendering
pip3 install moviepy
pip3 install "moviepy<2.0.0"

# deepmind control suite
pip3 install dm_control
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ def _main(argv):
],
"dm_control": ["dm_control"],
"gym_continuous": ["gymnasium<1.0", "mujoco"],
"rendering": ["moviepy"],
"rendering": ["moviepy<2.0.0"],
"tests": ["pytest", "pyyaml", "pytest-instafail", "scipy"],
"utils": [
"tensorboard",
Expand Down
2 changes: 1 addition & 1 deletion sota-check/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export MUJOCO_GL=egl
conda create -n rl-sota-bench python=3.10 -y
conda install anaconda::libglu -y
pip3 install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu121
pip3 install "gymnasium[accept-rom-license,atari,mujoco]" vmas tqdm wandb pygame moviepy imageio submitit hydra-core transformers
pip3 install "gymnasium[accept-rom-license,atari,mujoco]" vmas tqdm wandb pygame "moviepy<2.0.0" imageio submitit hydra-core transformers

cd /path/to/tensordict
python setup.py develop
Expand Down
2 changes: 1 addition & 1 deletion sota-implementations/multiagent/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Install vmas and dependencies:

```bash
pip install vmas
pip install wandb moviepy
pip install wandb "moviepy<2.0.0"
pip install hydra-core
```

Expand Down
Loading