-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyPy3.8 support #80
Comments
If I had to guess this is a bug or a change in the CPython API and something that has probably changed in PyPy. To define a python type in C/C++ you need a Line 305 in bd751fc
It looks like aggdraw is trying to leave this undefined by casting a https://python.readthedocs.io/en/latest/c-api/typeobj.html#c.PyTypeObject.tp_print You/we will need to find out what the proper way is to leave this field undefined. Maybe it should be set to NULL? But that doesn't really satisfy the |
Thanks for the quick response! I suppose there's no interest in dropping support for a language version declared EOL nearly 2 years ago? |
What do you mean? Dropping support for Python 2? I don't think we support it now. But that's not the point, this is the CPython C API. Their PyTypeObject struct includes a field for this. For binary compatibility it can't be removed, but I'm not sure what it should be to make PyPy happy. |
To clarify a little more: this binary compatibility is not a aggdraw thing, this is a CPython thing. |
Ah, misunderstood - I thought you meant something had been left in aggdraw for py2 compatibility. It does look like your travis config does run against 2.7 and 3.7; appveyor against 3.6 (EOL in a few days). |
We haven't had any new commits for quite a while so the CI is pretty out of date. As for the state of the repository, the I still think the PyPy issue should be something related to a change in PyPy and not necessarily a bug in aggdraw. I'd be surprised if we are the only project running into this. I would expect the PyPy change to be documented but I'm not really sure where to dive in. |
We can successfully install aggdraw on pypy3.7 (v7.3.7) and on CPython 3.8, but not pypy3.8 (v7.3.7). Does this output mean anything to anyone?
The text was updated successfully, but these errors were encountered: