-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test is not supported for ppc64le (power) architecture #51
Comments
@asellappen thanks for bringing this to our attention. As far as I know, we don't have any devs using this architecture, so it might be a bit difficult to debug. Can you try to check what the |
@mraspaud , Thanks for looking into this , confirmed that fft_metric returns False. |
What about the pycoast/pycoast/tests/test_pycoast.py Lines 61 to 66 in c9584be
We've had issues in the past where the pycoast tests aren't robust enough to even handle running on different operating systems. |
@djhoese rms returns below |
Is that when running all the tests? So all of them are fine except this one particular failing test? Interesting, but I'm not sure what could be wrong that would only effect ppc64le. |
Yes,all the test are passing excpet this case, I have tried to debug the func fft_proj_rms furthe and found there is an issue on returning value from numby call fft.fft2 for this case, Values returned for ps1 and ps2 are different when we compare this case with successful cases,Pls let me know if you need any further details, so that i can dig more if possible. def fft_proj_rms(a1, a2):
The below test case is failingPassing value to the func fft_proj_rms(a1, a2) as below value of a1 at fft_proj_rms [[[0 0 0] The same at Successful Test case 1,Passing value to the func fft_proj_rms(a1, a2) as below a1 [[[0 0 0] a2 [[[0 0 0] fr1 [[ 4669704. +0.j -589896.94275353 -377474.20341772j fr1 [[ 4669704. +0.j -589896.94275353 -377474.20341772j ps1 [[13.33857871 11.69060818 11.56754313 ... 10.57519522 11.56754313 ps2 [[13.33857871 11.69060818 11.56754313 ... 10.57519522 11.56754313 p1 [[ 0. -2.57235143 -2.46494666 ... -0.91738557 2.46494666 p2 [[ 0. -2.57235143 -2.46494666 ... -0.91738557 2.46494666 theta [[0. 0. 0. ... 0. 0. 0.] fr1 [[ 4593372. +0.j -529395.14502257 -352019.17099045j ps2 [[13.32426324 11.60657129 11.62114215 ... 10.62304911 11.62114215 p1 [[ 0. -2.55478224 -2.46663459 ... -0.84034403 2.46663459 p2 [[ 0. -2.55478224 -2.46663459 ... -0.84034403 2.46663459 theta [[0. 0. 0. ... 0. 0. 0.] fr1 [[ 4583004. +0.j -520542.66007104 -346809.5793856j fr1 [[ 4583004. +0.j -520542.66007104 -346809.5793856j ps1 [[13.32230047 11.59244497 11.63348367 ... 10.65237106 11.63348367 ps2 [[13.32230047 11.59244497 11.63348367 ... 10.65237106 11.63348367 p1 [[ 0. -2.55388119 -2.46086446 ... -0.871107 2.46086446 p2 [[ 0. -2.55388119 -2.46086446 ... -0.871107 2.46086446 theta [[0. 0. 0. ... 0. 0. 0.] rms 0.0 |
The RMS is only a check to compare two images. If we could save the image generated by the test and then compare it to the expected output maybe we could get an idea what is wrong. |
@djhoese ,Yes.That's right ,I am reaching out some expertise at my IBM team to get help for fixing this issue ,meanwhile i am putting on hold . |
Code Sample, a minimal, complete, and verifiable piece of code
test failing for the below on power arch
Problem description
Test is failing for power arch when we try to port power cpu arch support on this package,build is completed sucessfully and facing issue at test only.
Reason for build and test :-
I am working for IBM to port cpu arch ppc64le for open sources.This helps us simplify testing later when distributions are re-building and re-releasing,We typically build applications for customers and ISVs, and while we don't use this package directly,we do count on all of the packages in debian/ubuntu to build other packages. So we more likely have this as a second or third level dependency and couldn't tell you explicitly which features we use or our usage model.
Expected Output
should comple test test just like amd64
Actual Result, Traceback if applicable
pls refer https://travis-ci.com/github/asellappen/pycoast/jobs/457849733
Versions of Python, package at hand and relevant dependencies
PYTHON_VERSION=3.7 and its failing for all python version configured on travis job.
Thank you for reporting an issue !
The text was updated successfully, but these errors were encountered: