Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metop-C compatibility #80

Closed
carloshorn opened this issue Nov 19, 2020 · 3 comments
Closed

Metop-C compatibility #80

carloshorn opened this issue Nov 19, 2020 · 3 comments

Comments

@carloshorn
Copy link

The current version cannot process Metop-C files.
I have a hot fix, but maybe let us discuss the options.

The problem is that there is no entry in the dictionary metadata.TIME_COVERAGE and therefore the program raises a KeyError.
Adding the Metop-C data would fix this issue, but I would suggest to change the following lines:

time_cov_start, time_cov_end = TIME_COVERAGE[
get_gcmd_platform_name(ch4.attrs["platform_name"], with_category=False)
]

in favour of using TIME_COVERAGE.get(..., (None, None)), and add the time_cov_start metadata optionally (same as time_cov_end). The missing time_cov_start should raise a warning, but it should not be the show stopper.

What do you think?

@sfinkens
Copy link
Member

@carloshorn I agree, nice solution! Are you already working on it or shall I?

@carloshorn
Copy link
Author

@sfinkens, I can setup the PR.

@sfinkens
Copy link
Member

sfinkens commented Sep 9, 2021

Closing, as MetOp-C has been added by #84. Opened a new issue for the attribute issue (#90).

@sfinkens sfinkens closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants