Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floating point comparison #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

avalentino
Copy link

No description provided.

@avalentino avalentino force-pushed the bugfix/floating-point-comparison branch from 48ae2d2 to 7a6cb6e Compare December 9, 2023 09:25
@avalentino avalentino changed the title Fix floating point comparison [WIP] Fix floating point comparison Dec 9, 2023
@avalentino avalentino force-pushed the bugfix/floating-point-comparison branch from 7a6cb6e to 64a4b47 Compare December 9, 2023 09:49
@avalentino avalentino changed the title [WIP] Fix floating point comparison Fix floating point comparison Dec 9, 2023
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhoese
Copy link
Member

djhoese commented Dec 10, 2023

I think the dependencies for this project in pyproject.toml are wildly out of date. Xarray isn't even the date-formatted version number. I'm not saying you need to fix this, but someone from the maintainers needs to fix it or advise what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants