Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI build action to work without setup.py #172

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Nov 29, 2024

In #169 the setup.py was removed, but the CI action to build and deploy the released package was updated. This PR adapts the action to use python -m build command.

@pnuu pnuu added the bug label Nov 29, 2024
@pnuu pnuu self-assigned this Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (6fb6efd) to head (c4d523a).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   87.81%   87.84%   +0.02%     
==========================================
  Files          16       16              
  Lines        2626     2632       +6     
==========================================
+ Hits         2306     2312       +6     
  Misses        320      320              
Flag Coverage Δ
unittests 87.84% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, LGTM!

@coveralls
Copy link

Coverage Status

coverage: 87.807%. remained the same
when pulling c4d523a on pnuu:ci-update-build
into d582531 on pytroll:main.

@mraspaud mraspaud merged commit a754887 into pytroll:main Nov 29, 2024
18 checks passed
@pnuu pnuu deleted the ci-update-build branch November 29, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants