Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytz dependency #175

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Remove pytz dependency #175

merged 1 commit into from
Dec 12, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Dec 12, 2024

Python builtin datetime.timezone serves the same purpose

  • Closes #xxxx
  • Tests added
  • Fully documented

Python builtin datetime.timezone serves the same purpose
@djhoese djhoese requested review from adybbroe and pnuu December 12, 2024 15:26
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (c4d523a) to head (16f71f7).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   87.84%   87.83%   -0.01%     
==========================================
  Files          16       16              
  Lines        2632     2630       -2     
==========================================
- Hits         2312     2310       -2     
  Misses        320      320              
Flag Coverage Δ
unittests 87.83% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 87.798% (-0.009%) from 87.807%
when pulling 16f71f7 on djhoese:remove-pytz-dep
into 03e220f on pytroll:main.

@djhoese djhoese added dependencies Pull requests that update a dependency file enhancement bug and removed enhancement labels Dec 12, 2024
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the change, although I thought I already fixed all the datetime imports earlier on.

pyorbital/orbital.py Show resolved Hide resolved
@djhoese djhoese merged commit b3bb0ad into pytroll:main Dec 12, 2024
16 of 18 checks passed
@djhoese djhoese deleted the remove-pytz-dep branch December 12, 2024 16:07
@pnuu pnuu mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants