Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message type needs to be dataset when message contains dataset in posttroll-hook #44

Open
TAlonglong opened this issue Dec 1, 2021 · 1 comment
Assignees
Labels

Comments

@TAlonglong
Copy link
Collaborator

It look to me that the hook can produce both messages with file and dataset.

But the message type is hardcoded to file.

https://github.com/pytroll/pytroll-pps-runner/blob/main/nwcsafpps_runner/pps_posttroll_hook.py#L274

I think this needs to be fixed

@TAlonglong TAlonglong added the bug label Dec 1, 2021
@TAlonglong TAlonglong changed the title Message type needs to be dataset when message contains datasey Message type needs to be dataset when message contains dataset in posttroll-hook Dec 1, 2021
@TAlonglong
Copy link
Collaborator Author

TAlonglong commented Dec 1, 2021

OK this is maybe to as as easy.

Why is it necessary to use dataset? If this message is to be send to move-it-server it will fail.

I there for suggest to not use dataset at all, but make individual messages for each file in the dataset and this avoid the dataset problem

The code to make the mesage is about here:
https://github.com/pytroll/pytroll-pps-runner/blob/main/nwcsafpps_runner/pps_posttroll_hook.py#L335-L351

I suggest we loop over the dataset and generate a message for each file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants