Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ftp downloading for older python versions #81

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

mraspaud
Copy link
Member

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

@mraspaud mraspaud added the bug label Sep 18, 2023
@mraspaud mraspaud self-assigned this Sep 18, 2023
@mraspaud
Copy link
Member Author

@TAlonglong if you want to have a look...

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 38.87%. Comparing base (885f7c2) to head (77cb0f2).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
trollsched/satpass.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   38.85%   38.87%   +0.02%     
==========================================
  Files          15       15              
  Lines        2082     2086       +4     
==========================================
+ Hits          809      811       +2     
- Misses       1273     1275       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@TAlonglong TAlonglong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any problem with this change

@TAlonglong
Copy link
Collaborator

Don't looks like I can merge it.

Copy link
Contributor

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
But we should leave python 2 all together shortly!

@adybbroe adybbroe merged commit 5ca54ea into pytroll:main Nov 19, 2024
6 checks passed
@mraspaud mraspaud deleted the fix-ftp-dl branch November 19, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants