Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 88 command line option avoid as list #89

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

TAlonglong
Copy link
Collaborator

@TAlonglong TAlonglong commented May 8, 2024

@TAlonglong
Copy link
Collaborator Author

I added a test for this, but it does not work. Or the test fails as it should

It seems like the avoid pass is given weight 0, but still it is added to the schedule list.

But I couldn't figure out how to fix this. I need to look at this with someone else later.

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.50%. Comparing base (0e1319e) to head (e0f2bbc).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   55.52%   57.50%   +1.98%     
==========================================
  Files          15       15              
  Lines        2100     2125      +25     
==========================================
+ Hits         1166     1222      +56     
+ Misses        934      903      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@TAlonglong
Copy link
Collaborator Author

So, the existing code actually worked all the time. I was confused by the __str__and __eq__ when debugging the code. A call so some LOG triggered the __str__ but the actual compare uses of cource __eq__

And if the schedule has no conflicting passes with a pass in the avoid list it is scheduled anyway.

The test is updated accordingly

Copy link
Contributor

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adybbroe adybbroe merged commit a2d36e5 into pytroll:main Nov 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Change the avoid command line options to take a list
2 participants